-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize AArch64 SHA3 intrinsics #1552
Stabilize AArch64 SHA3 intrinsics #1552
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks. |
d12b01d
to
631eb00
Compare
These intrinsics are tested against clang and are known to produce the same results. @rfcbot fcp merge |
@rfcbot fcp merge |
Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members: No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
@rfcbot reviewed |
The checkboxes are greyed out for me (I can't tick my box), but I approve. |
I've ticked your box. |
🔔 This is now entering its final comment period, as per the review above. 🔔 psst @Amanieu, I wasn't able to add the |
Merging
|
This seems to be fallout from rust-lang/rust#119552 which was recently merged. Just add |
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. psst @Amanieu, I wasn't able to add the |
☔ The latest upstream changes (presumably 24068c7) made this pull request unmergeable. Please resolve the merge conflicts. |
Can you squash and rebase? |
e5f23f9
to
4a5204f
Compare
@Amanieu done |
Accidentally added in rust-lang#1552
See also: rust-lang/rust#117225