[breaking change]: mask argument type of _mm_shuffle_ps #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexcrichton so CI passed, shall I send a PR to rust-lang/rust to schedule a crater run ? |
|
@gnzlbg sure! |
|
I think we should just merge this and deal with the fallout. cc @rust-lang-nursery/libs @Amanieu |
|
I believe the crater fun from 6ish months ago was clean right? I forget now the original reason for closing, but I'm personally still in favor for this |
|
I think this is fine, we are just correcting an "incorrect" function signature and there are no crater failures. |
|
I'll send a PR to update stdsimd upstream, and will do a new crater run before the update. There is another breaking change in the pipeline, so I'll try to merge both. If the crater run fails we can always revert this. |
gnzlbg
added a commit
to gnzlbg/rust
that referenced
this pull request
Apr 22, 2019
This commit updates stdsimd and contains two breaking changes: * rust-lang/stdarch#733 * rust-lang/stdarch#586 We already did a crater run of 586 but we should do another one here.
bors
added a commit
to rust-lang/rust
that referenced
this pull request
Apr 25, 2019
Breaking update of stdsimd This commit updates stdsimd and contains two breaking changes: * rust-lang/stdarch#733 * rust-lang/stdarch#586 We already did a crater run of 586 but we should do another one here. r? @alexcrichton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE
If CI passes, I'll push this as a branch, and send a PR to rust-lang/rust to schedule a crater run. Depending on how much code this change breaks, we can re-evaluate what to do with issue #522 .