Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to the T-compiler meeting agenda #1711

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 0 additions & 18 deletions src/agenda.rs
Original file line number Diff line number Diff line change
Expand Up @@ -169,15 +169,6 @@ pub fn prioritization<'a>() -> Box<dyn Action> {
exclude_labels: vec!["beta-accepted"],
}),
},
QueryMap {
name: "beta_nominated_t_rustdoc",
kind: QueryKind::List,
query: Arc::new(github::Query {
filters: vec![],
include_labels: vec!["beta-nominated", "T-rustdoc"],
exclude_labels: vec!["beta-accepted"],
}),
},
// stable nomination queries
QueryMap {
name: "stable_nominated_t_compiler",
Expand All @@ -188,15 +179,6 @@ pub fn prioritization<'a>() -> Box<dyn Action> {
exclude_labels: vec!["stable-accepted"],
}),
},
QueryMap {
name: "stable_nominated_t_rustdoc",
kind: QueryKind::List,
query: Arc::new(github::Query {
filters: vec![],
include_labels: vec!["stable-nominated", "T-rustdoc"],
exclude_labels: vec!["stable-accepted"],
}),
},
// prs waiting on team queries
QueryMap {
name: "prs_waiting_on_team_t_compiler",
Expand Down
2 changes: 1 addition & 1 deletion templates/_issue.tt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{% macro render(issue, with_age="") %}"{{issue.title}}" [{{issue.repo_name}}#{{issue.number}}]({{issue.html_url}}) {% if with_age %}(last review activity: {{issue.updated_at_hts}}){% endif %}{% endmacro %}
{% macro render(issue, with_age="") %}"{{issue.title}}" [{{issue.repo_name}}#{{issue.number}}]({{issue.html_url}}){% if with_age %}(last review activity: {{issue.updated_at_hts}}){% endif %}{% endmacro %}
2 changes: 1 addition & 1 deletion templates/_issues.tt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{% import "_issue.tt" as issue %}

{% macro render(issues, indent="", branch="", with_age=false, empty="No issues this time.") %}
{% macro render(issues, indent="", branch="", with_age=false, empty="No issues at this time.") %}
{#- If "branch" is not empty add a trailing space but no newlines before or after -#}
{%- if branch -%}
{%- set branch = branch ~ " " -%}
Expand Down
46 changes: 28 additions & 18 deletions templates/prioritization_agenda.tt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@

---
tags: weekly, rustc
type: docs
---

# T-compiler Meeting Agenda YYYY-MM-DD
Expand Down Expand Up @@ -39,35 +40,35 @@ tags: weekly, rustc
(TIP) pick from [here](https://rust-lang.github.io/compiler-team/about/triage-meeting/#working-group-check-in)

@*WG-X* checkin by @**person1** ([previous checkin](https://hackmd.io/team/rust-compiler-team?nav=overview)):
> Checkin text
> Checkin text

@*WG-Y* checkin by @**person2** ([previous checkin](https://hackmd.io/team/rust-compiler-team?nav=overview)):
> Checkin text
> Checkin text

## Backport nominations

[T-compiler stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-compiler) / [T-compiler beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-compiler)
{{-issues::render(issues=beta_nominated_t_compiler, branch=":beta:", empty="No beta nominations for `T-compiler` this time.")}}
<!--
/poll Approve beta backport of #12345?
approve
decline
don't know
-->
{{-issues::render(issues=stable_nominated_t_compiler, branch=":stable:", empty="No stable nominations for `T-compiler` this time.")}}

[T-rustdoc stable](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Abeta-nominated+-label%3Abeta-accepted+label%3AT-rustdoc) / [T-rustdoc beta](https://github.com/rust-lang/rust/issues?q=is%3Aall+label%3Astable-nominated+-label%3Astable-accepted+label%3AT-rustdoc)
{{-issues::render(issues=beta_nominated_t_rustdoc, branch=":beta:", empty="No beta nominations for `T-rustdoc` this time.")}}
{{-issues::render(issues=stable_nominated_t_rustdoc, branch=":stable:", empty="No stable nominations for `T-rustdoc` this time.")}}

:back: / :shrug: / :hand:
<!--
/poll Approve stable backport of #12345?
approve
approve but does not justify new dot release
decline
don't know
-->

## PRs S-waiting-on-team

[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Aopen+label%3AS-waiting-on-team+label%3AT-compiler)
{{-issues::render(issues=prs_waiting_on_team_t_compiler, empty="No PRs waiting on `T-compiler` this time.")}}

### Oldest PRs waiting for review

(TIP) Curate this list before the meeting

[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-asc+label%3AS-waiting-on-review+draft%3Afalse+label%3AT-compiler)
{{-issues::render(issues=top_unreviewed_prs, with_age=true, empty="No unreviewed PRs on `T-compiler` this time.")}}

## Issues of Note

### Short Summary
Expand All @@ -83,13 +84,13 @@ tags: weekly, rustc
### P-critical

[T-compiler](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-compiler)
{{-issues::render(issues=p_critical_t_compiler, empty="No `P-critical` issues for `T-compiler` at this time.")}}
{{-issues::render(issues=p_critical_t_compiler, empty="No `P-critical` issues for `T-compiler` this time.")}}

[T-types](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-types)
{{-issues::render(issues=p_critical_t_types, empty="No `P-critical` issues for `T-types` at this time.")}}
{{-issues::render(issues=p_critical_t_types, empty="No `P-critical` issues for `T-types` this time.")}}

[T-rustdoc](https://github.com/rust-lang/rust/issues?q=is%3Aopen+label%3AP-critical+label%3AT-rustdoc)
{{-issues::render(issues=p_critical_t_rustdoc, empty="No `P-critical` issues for `T-rustdoc` at this time.")}}
{{-issues::render(issues=p_critical_t_rustdoc, empty="No `P-critical` issues for `T-rustdoc` this time.")}}

### P-high regressions

Expand All @@ -111,7 +112,16 @@ tags: weekly, rustc
[RFC](https://github.com/rust-lang/rfcs/issues?q=is%3Aopen+label%3AI-compiler-nominated)
{{-issues::render(issues=nominated_rfcs_t_compiler, empty="No I-compiler-nominated RFCs this time.")}}

### Oldest PRs waiting for review

(TIP) Curate this list before the meeting

[T-compiler](https://github.com/rust-lang/rust/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-asc+label%3AS-waiting-on-review+draft%3Afalse+label%3AT-compiler)
{{-issues::render(issues=top_unreviewed_prs, with_age=true, empty="No unreviewed PRs on `T-compiler` this time.")}}

## Next week's WG checkins

- @*WG-X* checkin by @**person1**
- @*WG-X* checkin by @**person2**

Next meetings' agenda draft: `<hackmd link>`
Loading