Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow for tracking PRs assignment #1773

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Workflow for tracking PRs assignment #1773

merged 1 commit into from
Feb 24, 2024

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented Feb 20, 2024 •
edited
Loading

This is the third try 😅 to land part of the work on #1753 (pull requests tracking and balanced assignment for the Rust project contributors).

This patch implements:

  • Added a new DB table with the fields to track how many PRs are assigned to a contributor
  • Initial DB table population with a one-off job, manually run.

r? @jackh726

This was referenced Feb 20, 2024
Open
Closed
@apiraino apiraino force-pushed the new-pull-request-assignment-2 branch 2 times, most recently from 578fa73 to 905ffee Compare February 20, 2024 16:53
@apiraino apiraino marked this pull request as ready for review February 20, 2024 16:54
apiraino
apiraino commented Feb 20, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
apiraino
apiraino commented Feb 20, 2024
View reviewed changes
src/main.rs Outdated Show resolved Hide resolved
@apiraino apiraino force-pushed the new-pull-request-assignment-2 branch from 905ffee to c1f5839 Compare February 20, 2024 16:58
@apiraino
Copy link
Contributor Author

The job starts but GH returns an error, so I'll check what's happening 🙂

jackh726
jackh726 reviewed Feb 20, 2024
View reviewed changes
github-graphql/PullRequestsOpen.gql Outdated Show resolved Hide resolved
github-graphql/PullRequestsOpen.gql Show resolved Hide resolved
github-graphql/src/lib.rs Outdated Show resolved Hide resolved
src/github.rs Outdated Show resolved Hide resolved
src/handlers/pull_requests_assignment_update.rs Outdated Show resolved Hide resolved
src/handlers/pull_requests_assignment_update.rs Outdated Show resolved Hide resolved
src/handlers/pull_requests_assignment_update.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
This was referenced Feb 21, 2024
Open
Closed
@apiraino apiraino force-pushed the new-pull-request-assignment-2 branch 2 times, most recently from bd97ce8 to d34bc21 Compare February 22, 2024 12:48
apiraino
apiraino commented Feb 22, 2024
View reviewed changes
src/github.rs Show resolved Hide resolved
jackh726
jackh726 reviewed Feb 22, 2024
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, seems very close. There are still a couple open comments from me and a couple new ones.

I don't think anything here is blocking. If you can get to it now, good. Otherwise, a TODO will be okay.

src/handlers/pull_requests_assignment_update.rs Outdated Show resolved Hide resolved
@apiraino
Copy link
Contributor Author

apiraino commented Feb 22, 2024 •
edited
Loading

Okay, seems very close. There are still a couple open comments from me and a couple new ones.

I don't think anything here is blocking. If you can get to it now, good. Otherwise, a TODO will be okay.

just a bit more time, I'm working on resolving the open comments because they do make sense :)

@apiraino apiraino force-pushed the new-pull-request-assignment-2 branch from d34bc21 to 24b9b6a Compare February 22, 2024 19:46
@apiraino apiraino force-pushed the new-pull-request-assignment-2 branch 3 times, most recently from 7e8b4fa to c23d51d Compare February 23, 2024 10:49
@apiraino
Copy link
Contributor Author

I think all the comments are now resolved 👍

@rustbot ready

@rustbot
Copy link
Collaborator

rustbot commented Feb 23, 2024

Error: The feature shortcut is not enabled in this repository.
To enable it add its section in the triagebot.toml in the root of the repository.

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

@apiraino
Import pull request assignments into triagebot
a75633d 
General overview at: rust-lang#1753

- Added a new DB table with the fields to track how many PRs are
  assigned to a contributor
- Initial DB table population with a one-off job, manually run.
@apiraino apiraino force-pushed the new-pull-request-assignment-2 branch from 41e29c8 to a75633d Compare February 23, 2024 11:04
jackh726
jackh726 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple comments that I'd like for you to followup on in another PR, but let's land this.

src/main.rs Show resolved Hide resolved
src/main.rs
for (idx, job) in jobs.into_iter().enumerate() {
let ctx = ctx.clone();
task::spawn(async move {
// Allow some spacing between starting jobs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also not going to block on this, but seems like we could also just spawn one task that runs through all the jobs. Or just not worry about the delay (we can always add it later if it's a problem).

@jackh726 jackh726 merged commit 75dc576 into rust-lang:master Feb 24, 2024
2 checks passed
@apiraino apiraino deleted the new-pull-request-assignment-2 branch February 26, 2024 11:36
@apiraino apiraino mentioned this pull request Feb 26, 2024
Open
apiraino added a commit to apiraino/triagebot that referenced this pull request Feb 27, 2024
@apiraino
Add Zulip integration to query PRs assignment
6b50e37 
Implement a command to query from Zulip the number of assigned PRs. The
command returns own Github username and assigned PRs to review.

This command cannot be be used to check other peoples' work. Allows testing
that the DB queries created in rust-lang#1773 are working correctly.
apiraino added a commit to apiraino/triagebot that referenced this pull request Feb 27, 2024
@apiraino
Add Zulip integration to query PRs assignment
16804b1 
Implement a command to query from Zulip the number of assigned PRs. The
command returns own Github username and assigned PRs to review.

This command cannot be be used to check other peoples' work. Allows testing
that the DB queries created in rust-lang#1773 are working correctly.
@apiraino apiraino mentioned this pull request Feb 27, 2024
Merged
1 task
apiraino added a commit to apiraino/triagebot that referenced this pull request Feb 27, 2024
@apiraino
Add Zulip integration to query PRs assignment
6012f1c 
Implement a command to query from Zulip the number of assigned PRs. The
command returns own Github username and assigned PRs to review.

This command cannot be be used to check other peoples' work. Allows testing
that the DB queries created in rust-lang#1773 are working correctly.
apiraino added a commit to apiraino/triagebot that referenced this pull request Feb 27, 2024
@apiraino
Add Zulip integration to query PRs assignment
a200f91 
Implement a command to query from Zulip the number of assigned PRs. The
command returns own Github username and assigned PRs to review.

This command cannot be be used to check other peoples' work. Allows testing
that the DB queries created in rust-lang#1773 are working correctly.
apiraino added a commit to apiraino/triagebot that referenced this pull request Feb 27, 2024
@apiraino
Add Zulip integration to query PRs assignment
1196b6e 
Implement a command to query from Zulip the number of assigned PRs. The
command returns own Github username and assigned PRs to review.

This command cannot be be used to check other peoples' work. Allows testing
that the DB queries created in rust-lang#1773 are working correctly.
@ehuss ehuss mentioned this pull request Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackh726 jackh726 jackh726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apiraino @rustbot @jackh726