Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webhook handler to update PR workload queues #1781

Merged

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented Mar 6, 2024

This is the third step to implement tracking the pull request workload designed in #1753

In this patch we enable handling GH webhooks when a PR is assigned or unassigned.

@apiraino apiraino force-pushed the add-webhook-to-update-pr-workload-queues branch from a906359 to 1153a33 Compare March 6, 2024 17:23
src/db.rs Show resolved Hide resolved
@apiraino apiraino force-pushed the add-webhook-to-update-pr-workload-queues branch from 1153a33 to 685e739 Compare March 7, 2024 18:55
src/github.rs Outdated Show resolved Hide resolved
@apiraino apiraino marked this pull request as ready for review March 7, 2024 19:00
@apiraino
Copy link
Contributor Author

apiraino commented Mar 7, 2024

@jackh726 I've removed a lot of code ^^, now I have a better understanding. PR is ready for a first review when you have time. Thanks!

src/config.rs Show resolved Hide resolved
@apiraino apiraino force-pushed the add-webhook-to-update-pr-workload-queues branch 2 times, most recently from e6d4d03 to 9c88e4b Compare March 11, 2024 17:15
@apiraino apiraino force-pushed the add-webhook-to-update-pr-workload-queues branch from 3e6590b to e693127 Compare March 11, 2024 17:33
@apiraino
Copy link
Contributor Author

thank you @GuillaumeGomez it looks much better now :)

@apiraino apiraino force-pushed the add-webhook-to-update-pr-workload-queues branch from e693127 to 1e7a875 Compare March 11, 2024 17:36
Copy link
Member

@jackh726 jackh726 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@jackh726 jackh726 merged commit 0129fcc into rust-lang:master Mar 11, 2024
2 checks passed
@jackh726
Copy link
Member

@apiraino can you make a PR to rust-lang/rust to add the config option to the triagebot.toml

@apiraino apiraino deleted the add-webhook-to-update-pr-workload-queues branch March 11, 2024 20:03
apiraino added a commit to apiraino/triagebot that referenced this pull request Apr 19, 2024
- Fix a wrong migration introduced in rust-lang#1781
- Clarify how DB migrations should be added to the triagebot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants