Limit validate_config actions. #1804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackh726
approved these changes
May 3, 2024
| @@ -13,6 +14,12 @@ pub(super) async fn parse_input( | |||
| event: &IssuesEvent, | |||
| _config: Option<&ValidateConfig>, | |||
| ) -> Result<Option<()>, String> { | |||
| if !matches!( | |||
| event.action, | |||
| IssuesAction::Opened | IssuesAction::Reopened | IssuesAction::Synchronize | |||
There was a problem hiding this comment.
Whenever commits are pushed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits which actions the validate_config handler will handle. There was a problem where it was validating the config on every action. This means that if there is an invalid config, and any action was performed on the PR (like adding a label, or assigning someone), it would post a comment about the invalid config.
This is particularly a problem with old closed PRs that modified
triagebot.toml. Minor actions like adding milestones or labels shouldn't re-trigger validation.Fixes #1802