Replace CStr::from_ptr()
with CStr::from_bytes_with_nul()
#82
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #81 (comment)
CStr::from_ptr()
isunsafe
because it reads a raw pointer, and searches for a terminating nul character in the pointed region of memory.This is unnecessary as both calls already initialize a given number of characters and terminate with a nul, allowing us to pass a sized and initialized slice (without casting
*const MaybeUninit<u8>
to*const u8
) directly toCStr::from_bytes_with_nul()
(available since Rust 1.10, unlikeCStr::from_bytes_until_nul()
which was only stabilized in 1.69). Unfortunately allstd
helper APIs to initialize slices ofMaybeUninit
are still unstable, making this less ideal to write at the moment.