Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndk-build,cargo-apk: Default target_sdk_version to 30 or lower #203

Merged
merged 1 commit into from
Nov 24, 2021

Commits on Nov 24, 2021

  1. ndk-build,cargo-apk: Default target_sdk_version to 30 or lower

    As discussed in [197] setting `target_sdk_version` to the "arbitrary"
    highest available SDK version is nonsense.  This target version (unlike
    `min_sdk_version` which defines the least set of symbols that should be
    available) has real impact on the runtime of an application, in
    particular the compatibility or stringency of rules Android applies to
    your application.  Certain APIs may not work at all or be heavily
    restricted on newer target versions because they are deemed too
    dangerous, and Android expects the user has tested their app against
    these limitations and is communicating this by setting
    `target_sdk_version` to that particular value.  Hence this shouldn't
    change purely based on the environment, even for the default.
    
    To retain some backwards compatibility with previous `cargo-apk` we set
    this to level 30 which is the least [required by Google Play] today, and
    exactly what users will have been targeting using NDK r22 (assuming the
    SDK for this `platform` was installed as well) since SDK version 31
    support with NDK r23 only [arrived just last week].
    
    [197]: #197 (comment)
    [required by Google Play]: https://developer.android.com/distribute/best-practices/develop/target-sdk
    [arrived just last week]: #189
    MarijnS95 committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    8a93ad9 View commit details
    Browse the repository at this point in the history