x86 support #115

iamwacko · 2023-04-27T04:25:26Z

This PR enables x86 and adds x86 testing in CI. Currently on Linux is supported as a host. I'm not to partial to Windows. #114

dvc94ch · 2023-04-27T06:25:50Z

Can't you merge it with the existing tasks?

dvc94ch · 2023-04-27T15:44:48Z

the ci is broken, once it's green, lgtm

This should fix the broken CI

dvc94ch · 2023-04-27T19:17:12Z

more typos. I think you can open a PR against your own master so you don't have to wait for me to approve...

I really hope it is. I also opened a PR against my own master, as suggested.

I wish I could test GitHub actions locally. I'm really feeling the "it worked on my machine" right now.

openssl is very annoying. Any chance we could change it to rustls?

dvc94ch · 2023-04-29T06:20:17Z

.github/workflows/ci.yml

+      uses: hecrj/setup-rust-action@v1
+      with:
+        rust-version: stable
+        targets: "i686-unknown-linux-gnu"


Shouldn't be necessary. xbuild automatically downloads the required targets using rustup

Maybe it is supposed to, but

error[E0463]: can't find crate for `core` | = note: the `i686-unknown-linux-gnu` target may not be installed = help: consider downloading the target with `rustup target add i686-unknown-linux-gnu`

says otherwise.

Then maybe something is missing somewhere...

This used to be hardcoded but should be fixed now since #139. @iamwacko can you rebase, remove this setup from the CI (because xbuild must do it to provide a more-or-less out-of-the-box experience), and retest?

dvc94ch · 2023-05-02T08:59:09Z

who still uses 32bit anymore? all new devices intended to run a desktop or mobile app are 64bit and have been for years now. outside of embedded systems 32bit is pretty much gone.

wiredmatt · 2023-10-16T23:53:27Z

who still uses 32bit anymore? all new devices intended to run a desktop or mobile app are 64bit and have been for years now. outside of embedded systems 32bit is pretty much gone.

I have a Xiaomi phone, brand known for scamming customers by selling them phones with this kind of setup

See this and this.

My device uses armeabi-v7a, and I'm unable to build using either xbuild or cargo-apk without 32bit support. According to those people with actual games released, armeabi-v7a seems to be the most popular architecture in customer devices.

Most people who play mobile games don't live in first world countries, that's the deal. Probably most are from Asia / LATAM / somewhere else, so replying to your question, probably half the world population is still using 32bit / 32bit based architecture devices.

And almost forgot, this as well.

Most Android phones have ARM chipsets. However, many ChromeOS devices use x86 chips. The difference is not important for basic apps written in Kotlin or Java. However, for apps written in native code, including those created with game engines, the chipset in the device can be an important concern.
Ideally, all apps and games with native code ship with all four major Android ABIs (Application Binary Interfaces): armeabi-v7a (arm32), arm64-v8a (arm64), x86 (x86_32), and x86_64. This provides the best performance and lowest battery consumption for each device. For example, a cmake-based build.gradle file might contain...

p0ryae · 2023-11-09T05:51:47Z

I completely agree with @wiredmatt.

who still uses 32bit anymore? all new devices intended to run a desktop or mobile app are 64bit and have been for years now. outside of embedded systems 32bit is pretty much gone.

That's a pretty bold statement. The project README says the following:

The goal of xbuild is making native app development as easy as web development.

Why adding more support a bad practice in this case? Saying that "who still uses 32bit anymore" unless there's a reasonable program design explanation is fairly bias and impractical. Adding 32-bit support will increase the project's usability and make it reach to a broader audience, which is a positive development, not a negative one.

MarijnS95 · 2023-11-09T09:34:13Z

xbuild/src/lib.rs

+        // 32 bit binaries can run on 64 bit hardware, of particular use for testing
+        // This way 32 bit xbuild will produce 32 bit binaries, unless commanded otherwise
+        if cfg!(target_arch = "x86") {
+            Ok(false)


Not sure I follow. This doesn't seem correct as you might be breaking fully-native builds here? That's where xbuild should return true for this function.

MarijnS95 · 2023-11-09T09:34:42Z

appimage/assets/runtime-i686

What's the source of this file?

MarijnS95 · 2023-11-09T09:35:04Z

.github/workflows/ci.yml

      run: ./x new template
-
+      


Please trim (don't add) unnecessary whitespace.

MarijnS95

Mostly seeing lots of unnecessary bits in in ci.yml, the rest is mostly uncommenting exisisting x86 codepaths which looks good :)

MarijnS95 · 2023-11-09T09:36:28Z

.github/workflows/ci.yml

+    - uses: actions/upload-artifact@v3
+      with:
+        name: i686-x
+        path: bin/x


Might be nice to add the .exe suffix for Windows... And add a 32-bit Windows build?

MarijnS95 · 2023-11-09T09:36:51Z

.github/workflows/ci.yml


    - name: install x
+      if: ${{ matrix.host-arch == 'x64'}}


Suggested change

if: ${{ matrix.host-arch == 'x64'}}

if: ${{ matrix.host-arch == 'x64' }}

MarijnS95 · 2023-11-09T09:37:06Z

.github/workflows/ci.yml

      uses: actions/download-artifact@v3
      with:
        name: ${{ matrix.host }}-x
+
+    - name: install x i686
+      if: ${{ matrix.host-arch == 'x86'}}


Suggested change

if: ${{ matrix.host-arch == 'x86'}}

if: ${{ matrix.host-arch == 'x86' }}

MarijnS95 · 2023-11-09T09:37:24Z

.github/workflows/ci.yml

    steps:
    - name: install rust
+      if: ${{ matrix.target.arch == 'x64'}}


Suggested change

if: ${{ matrix.target.arch == 'x64'}}

MarijnS95 · 2023-11-09T09:37:33Z

.github/workflows/ci.yml

+
+    - name: install rust i686
+      if: ${{ matrix.target.arch == 'x86' }}
+      uses: hecrj/setup-rust-action@v1
+      with:
+        rust-version: stable
+        targets: "i686-unknown-linux-gnu"


Suggested change

- name: install rust i686

if: ${{ matrix.target.arch == 'x86' }}

uses: hecrj/setup-rust-action@v1

with:

rust-version: stable

targets: "i686-unknown-linux-gnu"

MarijnS95 · 2023-11-09T09:38:27Z

.github/workflows/ci.yml

    - run: chmod +x ./x
      if: ${{ matrix.host == 'ubuntu-latest' || matrix.host == 'macos-latest' }}

    - name: install llvm ubuntu
-      if: ${{ matrix.host == 'ubuntu-latest' }}
+      if: ${{ matrix.host == 'ubuntu-latest'}}


Revert all unnecessary whitespace changes:

Suggested change

if: ${{ matrix.host == 'ubuntu-latest'}}

if: ${{ matrix.host == 'ubuntu-latest' }}

MarijnS95 · 2023-11-09T09:38:32Z

.github/workflows/ci.yml

@@ -87,18 +128,31 @@ jobs:
        java-version: 11

    - name: install linux dependencies
-      if: ${{ matrix.host == 'ubuntu-latest' }}
+      if: ${{ matrix.host == 'ubuntu-latest'}}


Suggested change

if: ${{ matrix.host == 'ubuntu-latest'}}

if: ${{ matrix.host == 'ubuntu-latest' }}

MarijnS95 · 2023-11-09T09:38:43Z

.github/workflows/ci.yml

      run: sudo apt-get update && sudo apt-get install libwebkit2gtk-4.0-dev libgtk-3-dev squashfs-tools

+    - name: install dependencies for i686
+      if: ${{ matrix.host == 'ubuntu-latest'}}


Suggested change

if: ${{ matrix.host == 'ubuntu-latest'}}

if: ${{ matrix.host == 'ubuntu-latest' }}

MarijnS95 · 2023-11-09T09:38:51Z

.github/workflows/ci.yml

    - name: create project
+      if: ${{ !((matrix.host == 'macos-latest' || matrix.host == 'windows-latest' ) && matrix.host-arch == 'x86')}}


Suggested change

if: ${{ !((matrix.host == 'macos-latest' || matrix.host == 'windows-latest' ) && matrix.host-arch == 'x86')}}

if: ${{ !((matrix.host == 'macos-latest' || matrix.host == 'windows-latest') && matrix.host-arch == 'x86') }}

MarijnS95 · 2023-11-09T09:39:52Z

.github/workflows/ci.yml

    - name: build project
      if: >
-        !(matrix.host == 'macos-latest' && matrix.target.platform == 'linux' ||
-          matrix.host == 'windows-latest' && contains(fromJson('["linux", "macos", "ios"]'), matrix.target.platform))
+        ${{
+          !(matrix.host-arch == 'x64' && matrix.target.arch == 'x86' ||
+            matrix.host == 'macos-latest' && matrix.host-arch == 'x86' ||
+            matrix.host == 'windows-latest' && matrix.host-arch == 'x86' ||
+            matrix.host == 'macos-latest' && matrix.target.platform == 'linux' ||
+            matrix.host == 'windows-latest' && contains(fromJson('["linux", "macos", "ios"]'), matrix.target.platform)
+          )
+        }}    


This thing is getting out of hand, perhaps we can create a separate job: for it with a matrix that uses exclude/include instead.

feat: initial 32 bit support

c4d03e2

MarijnS95 linked an issue Apr 27, 2023 that may be closed by this pull request

32 bit support #114

Open

chore: cleaned up ci.yml

fabe787

dvc94ch approved these changes Apr 27, 2023

View reviewed changes

fix: typos in ci.yml

c9ebfcc

This should fix the broken CI

iamwacko added 19 commits April 27, 2023 12:25

fix: should be the last typo

fb93a17

I really hope it is. I also opened a PR against my own master, as suggested.

fix: target to targets

1d73dae

chore: install gcc-multilib

6e60de5

chore: install openssl

e51dc78

I wish I could test GitHub actions locally. I'm really feeling the "it worked on my machine" right now.

fix: add sudo where needed

11a9d12

fix: more openssl fixes

cd3d3bf

fix: satisfy lints by removing uneeded returns

43e5c9a

fix: typo

a696e0b

fix: even more typos in ci.yml

31c0e68

fix: don't need different llvm

9e66362

fix: libssl for 32 bit

b292f33

fix: more ssl stuff

b7bd57b

fix: more ssl stuff

f5613b9

openssl is very annoying. Any chance we could change it to rustls?

fix: more ssl

58f2ad7

fix: install i686 at the right time

1eeb1da

chore: make sure right software is running on the right hosts

844708a

fix: pkg config weirdness

92ef8b7

fix: gcc-multilib

167077a

fix: libglib install

10402ee

dvc94ch reviewed Apr 29, 2023

View reviewed changes

iamwacko added 2 commits April 29, 2023 11:59

fix: this should fix the rest of the problems

193a008

fix: set PKG_CONFIG_SYSROOT_DIR

2e18d0e

iamwacko added 6 commits April 30, 2023 15:02

fix: typo

1d52b22

fix: stop building when it isn't supposed to

4523168

fix: stop running on macos-latest

8261002

fix: make ci.yml valid

00461f8

fix: make ci.yml run

77a6f34

fix: typo

b9b4bb5

MarijnS95 reviewed Nov 9, 2023

View reviewed changes

appimage/assets/runtime-i686

Copy link

Member

MarijnS95 Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the source of this file?

MarijnS95 reviewed Nov 9, 2023

View reviewed changes

.github/workflows/ci.yml

run: ./x new template

Copy link

Member

MarijnS95 Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please trim (don't add) unnecessary whitespace.

MarijnS95 requested changes Nov 9, 2023

View reviewed changes

MarijnS95 mentioned this pull request Nov 27, 2023

Feature: support android x86 #153

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x86 support #115

x86 support #115

iamwacko commented Apr 27, 2023 •

edited

Loading

dvc94ch commented Apr 27, 2023

dvc94ch commented Apr 27, 2023

dvc94ch commented Apr 27, 2023

dvc94ch Apr 29, 2023

iamwacko Apr 29, 2023

dvc94ch Apr 29, 2023

MarijnS95 Nov 9, 2023

dvc94ch commented May 2, 2023

wiredmatt commented Oct 16, 2023 •

edited

Loading

p0ryae commented Nov 9, 2023 •

edited

Loading

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

MarijnS95 left a comment

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

MarijnS95 Nov 9, 2023

	if: ${{ matrix.host-arch == 'x64'}}
	if: ${{ matrix.host-arch == 'x64' }}

	if: ${{ matrix.host-arch == 'x86'}}
	if: ${{ matrix.host-arch == 'x86' }}

	if: ${{ matrix.host == 'ubuntu-latest'}}
	if: ${{ matrix.host == 'ubuntu-latest' }}

		- name: create project
		if: ${{ !((matrix.host == 'macos-latest' \|\| matrix.host == 'windows-latest' ) && matrix.host-arch == 'x86')}}

x86 support #115

Are you sure you want to change the base?

x86 support #115

Conversation

iamwacko commented Apr 27, 2023 • edited Loading

dvc94ch commented Apr 27, 2023

dvc94ch commented Apr 27, 2023

dvc94ch commented Apr 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dvc94ch commented May 2, 2023

wiredmatt commented Oct 16, 2023 • edited Loading

p0ryae commented Nov 9, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MarijnS95 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iamwacko commented Apr 27, 2023 •

edited

Loading

wiredmatt commented Oct 16, 2023 •

edited

Loading

p0ryae commented Nov 9, 2023 •

edited

Loading