use platform dependent c_char instead of hardcoded i8

[mike-kfed]

this should fix issue #351

I am willing to adapt to your preferences, but this works for me (tm)

[crunchy234]

It'd be great to get this in so that we can continue to use our linux arm instances

[seddonm1]

I have tested this on both x86_64 and aarch64 and it works. Would be great to see it merged.

[Dirreke]

And also this @termoshtt .Thanks very much!

[leecbaker]

@mike-kfed Thanks for putting this together!

Is there a reason to use libc::c_char instead of std::ffi::c_char or std::os::raw::c_char?

I think either of those may be equivalent, and avoids adding the dependency on libc.

[mike-kfed]

@leecbaker honestly I just followed the advice found in an open issue and "just wanted to make it work" (tm) ;)

I'll remove the dependency on libc, you are correct the other Rust std lib c_char definitions should be fine too.

[daniestevez]

I'm using this in armv7-unknown-linux-gnueabihf and it works too.

[FylmTM]

Encountered this issue today when our CI was switched to AWS C7g instances, that are using ARM Graviton3 processors.

It seems that this PR fixes the issue.
Would it possible to merge it, so that it can become available in upstream? 👀
Thankie!

[daniestevez]

Pinging again on this PR. What would be required to get this or something similar merged?