-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assertion failed: !nan.is_sign_positive() && !nan.is_sign_negative() #312
Comments
I'm working on this. |
Merged
This is fixed on both master and next now. |
bors bot
added a commit
to rust-num/num-traits
that referenced
this issue
Mar 1, 2018
41: Various improvements to FloatCore r=vks a=cuviper - New macros simplify forwarding method implementations. - `Float` and `Real` use this to compact their implementations. - `FloatCore` now forwards `std` implementations when possible. - `FloatCore` now requires `NumCast`, like `Float does. - New additions to `FloatCore`: - Constants like `min_value()` -> `f64::MIN` - Rounding methods `floor`, `ceil`, `round`, `trunc`, `fract` - `integer_decode` matching `Float`'s - Fix NAN sign handling in `FloatCore` (rust-num/num#312, rust-lang/rust#42425) - Fix overflow in `FloatCore::powi` exponent negation. - Add doctests to all `FloatCore` methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The standard library has changed behavior: issue rust-lang/rust#42425, pr rust-lang/rust#42431
This breaks our tests on nightly:
I think we'll have to drop our own expectations about NaN here, and just let it follow whatever std does, whether old or new. We also have our own implementations for
no_std
on thenext
branch, which should probably follow the new behavior.The text was updated successfully, but these errors were encountered: