rework crate to allocationless #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An overall rework of structures to make the crate allocationless. However, a new feature `allocator_api` has been added in addition to these changes, which allows use of `PlatformInfo` and some other allocating structures, by providing a `core::alloc::Allocator` in the constructor of these types. This allows semantic interfacing with existing allocation APIs, while also ensuring we aren't using the `alloc` crate allocation behaviour by default, as it isn't very extensible for use in bare-metal development contexts.
IsaacWoods
requested changes
Oct 30, 2022
There was a problem hiding this comment.
Great stuff, thanks for persevering with this despite the Git troubles. This is looking mostly good, I've left some comments here and there (a few apply generally rather than to the specific places I've marked).
A few are nits but would really bring down the diff size, which would definitely be worth it because a few parts of this PR, which'll all end up in a single commit, have their subtleties.
|
Alright, unless you have more nits or changes you'd like, I believe this PR is all finished up. |
IsaacWoods
approved these changes
Oct 31, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An overall rework of structures to make the crate allocationless. However, a new feature
allocator_apihas been added in addition to these changes, which allows use ofPlatformInfoand some other allocating structures, by providing acore::alloc::Allocatorin the constructor of these types. This allows semantic interfacing with existing allocation APIs, while also ensuring we aren't using thealloccrate allocation behaviour by default, as it isn't very extensible for use in bare-metal development contexts.