Use x86_64-unknown-uefi target #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rust now supports uefi as a build target: rust-lang/rust#56769 This change mainly eliminates references to the custom JSON target file. It also requires that the entry point's name be changed to `efi_main`. Note that the "C" abi is now correct for EFI applications, but will still be incorrect when uefi-rs is brought in as an external dependancy for a different target. This means the entry point should always be `extern "C"` while the table of function pointers should be `extern "win64"`.
josephlr
force-pushed
the
target
branch
3 times, most recently
from
cf3b04b
to
cd02b2f
Compare
|
@GabrielMajeri I can't figure out why the Travis run of QEMU is dropping back into the EFI shell with this change. I cannot seem to reproduce the failure locally. |
|
I've updated OVMF and ran the build again and it seems to have worked for now. Running QEMU + OVMF in CI always caused us problems, but it should be unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust now supports uefi as a build target: rust-lang/rust#56769
This change mainly eliminates references to the custom JSON target
file. It also requires that the entry point's name be changed to
efi_main.Note that the "C" abi is now correct for EFI applications, but will
still be incorrect when uefi-rs is brought in as an external dependancy
for a different target. This means the entry point should always be
extern "C"while the table of function pointers should beextern "win64".