Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Service Binding, DHCP4, IP4 Config2, HTTP, and TLS Config Protocols #952

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ben-krieger
Copy link
Contributor

@ben-krieger ben-krieger commented Oct 5, 2023

As part of a private project, I needed additional network protocols, so I added these bindings. The private project has shifted in scope a bit, so I never got around to cleaning this work up. However, I wanted to make sure to at least open a PR in case this work was of use to someone else and they wished to either take on completing the higher level (above uefi-raw) impls or wished to accept it as is: working, but somewhat incomplete.

(Specifically, the raw FFI bindings to C are complete, but the higher level protocols using Rust types in the uefi package do not make use of all the lower protocol functions.)

You may also wish to separate out the first two commits, which deal with Service Binding protocol. This was necessary to implement network protocols, but is technically separate and involves a complex set of changes to, including a proc macro.

This has been tested mainly with QEMU+OVMF.

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

@phip1611
Copy link
Contributor

phip1611 commented Oct 6, 2023

Hey, nice, thanks for the contribution! I probably don't have the time to look into this soon, but nevertheless it's a good starting point for someone other to polish the MR a bit and then merge it eventually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants