Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for Misc Issue #164 #167

Merged
merged 5 commits into from
Dec 4, 2023
Merged

PR for Misc Issue #164 #167

merged 5 commits into from
Dec 4, 2023

Conversation

paulsohn
Copy link
Contributor

@paulsohn paulsohn commented Dec 4, 2023

This is a resolution of #164.

I couldn't implement method chaining for context handlers, due to their dyn nature.

Copy link
Member

@toku-sa-n toku-sa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just one nit.

src/registers/doorbell.rs Outdated Show resolved Hide resolved
Co-authored-by: Hiroki Tokunaga <[email protected]>
@toku-sa-n toku-sa-n merged commit 7d9eb7d into rust-osdev:main Dec 4, 2023
1 check passed
toku-sa-n added a commit to toku-sa-n/xhci that referenced this pull request Dec 5, 2023
toku-sa-n added a commit that referenced this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants