Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove direct stdweb support #178

Merged
merged 2 commits into from
Jan 2, 2021
Merged

Remove direct stdweb support #178

merged 2 commits into from
Jan 2, 2021

Conversation

newpavlov
Copy link
Member

@newpavlov newpavlov commented Dec 7, 2020

Closes #175.

IIUC getrandom still can be used with the stdweb toolchain, since its recent versions are compatible with wasm-bindgen.

cc @koute

@josephlr
Copy link
Member

josephlr commented Dec 7, 2020

Thanks for opening this, I'll merge this one last (after a point release), so there's at least some easy way for users stuck on cargo web to pin a version.

@newpavlov
Copy link
Member Author

I think similarly regarding the version pinning escape hatch. But we already have released v0.2.0, haven't we?

@josephlr
Copy link
Member

josephlr commented Dec 7, 2020

I think similarly regarding the version pinning escape hatch. But we already have released v0.2.0, haven't we?

That's correct. I was thinking to release any minor fixes as 0.2.1 and then drop XP and stdweb support in 0.2.2.

I wouldn't consider dropping already broken support to be a major version change (but I'm not 100% sure). Does that sounds reasonable?

@newpavlov
Copy link
Member Author

I was thinking to release any minor fixes as 0.2.1 and then drop XP and stdweb support in 0.2.2.

Honestly, I don't think it worth the trouble. But if you are willing to cut those releases, it's fine by me.

Does that sounds reasonable?

Strictly speaking, I think it can be considered a breaking change. But practically speaking, I think potential WinXP/stdweb users would prefer to have the version pinning escape hatch, compared to a v0.3 release used by rand v0.8 without any support of those use-cases whatsoever. So I am in favor of dropping their support in v0.2.

@newpavlov
Copy link
Member Author

@josephlr
Can you review this and the other two PRs? It would be nice to release these changes before rand v0.8. Or do you plan to do the v0.2.1 release with minor fixes?

Copy link
Member

@josephlr josephlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not that this means we won't be able to use pure cargo web builds anymore, but I don't think that solution is maintained anymore, so that seems fine.

@josephlr josephlr merged commit 77740f8 into master Jan 2, 2021
@newpavlov newpavlov deleted the stdweb branch January 2, 2021 10:55
@josephlr josephlr mentioned this pull request Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove stdweb support (RUSTSEC-2020-0056)
2 participants