-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove direct stdweb support #178
Conversation
Thanks for opening this, I'll merge this one last (after a point release), so there's at least some easy way for users stuck on |
I think similarly regarding the version pinning escape hatch. But we already have released v0.2.0, haven't we? |
That's correct. I was thinking to release any minor fixes as 0.2.1 and then drop XP and stdweb support in 0.2.2. I wouldn't consider dropping already broken support to be a major version change (but I'm not 100% sure). Does that sounds reasonable? |
Honestly, I don't think it worth the trouble. But if you are willing to cut those releases, it's fine by me.
Strictly speaking, I think it can be considered a breaking change. But practically speaking, I think potential WinXP/ |
@josephlr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that this means we won't be able to use pure cargo web
builds anymore, but I don't think that solution is maintained anymore, so that seems fine.
Closes #175.
IIUC
getrandom
still can be used with thestdweb
toolchain, since its recent versions are compatible withwasm-bindgen
.cc @koute