Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs.rs fails to load #1001

Closed
zancas opened this issue Jul 19, 2020 · 4 comments
Closed

docs.rs fails to load #1001

zancas opened this issue Jul 19, 2020 · 4 comments

Comments

@zancas
Copy link

zancas commented Jul 19, 2020

For some subset of the rand_core docs, docs.rs fails to load:

https://docs.rs/rand_core/0.5.1/src/rand_core/os.rs.html#48

Perhaps it's related to this CI failure:

https://travis-ci.org/github/rust-random/rand/builds/709648207

?

@bjorn3
Copy link
Contributor

bjorn3 commented Jul 19, 2020

os.rs is only used when the getrandom feature is enabled. I guess it was nit enabled when documenting the crate.

@newpavlov
Copy link
Member

Currently optional features are not enabled during doc generation. I think we can close this issue in favor of #986.

@dhardy
Copy link
Member

dhardy commented Jul 20, 2020

I disagree. There's a line at the bottom of the master Cargo.toml enabling all features for docs.rs, unfortunately this doesn't apply recursively. This was added to rand_core/Cargo.toml 8 months ago, which was since the last release of rand_core, so essentially it will be resolved on the next release already. (Maybe we should hurry that up?)

@dhardy
Copy link
Member

dhardy commented Aug 28, 2020

Since the fix is already merged, I might as well close this.

@dhardy dhardy closed this as completed Aug 28, 2020
@dhardy dhardy mentioned this issue Aug 28, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants