Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add package metadata flags to rand_core to document OsRng on docs.rs #1018

Closed
hdevalence opened this issue Aug 18, 2020 · 3 comments
Closed

Comments

@hdevalence
Copy link

The rand_core Cargo.toml doesn't specify std as a default feature (fine) but also doesn't specify it with docs.rs metadata fields, so when looking at the rand_core docs, the OsRng type does not appear anywhere in the rendered docs. This is confusing to match up with code that uses rand_core::OsRng.

Adding

[package.metadata.docs.rs]
features = ["std"]

is one potential fix to this issue.

@newpavlov
Copy link
Member

I think we can close this issue as a duplicate of #986.

@dhardy
Copy link
Member

dhardy commented Aug 19, 2020

More like a duplicate of #1001. @hdevalence's suggestion fixes this and is mostly orthogonal to #986. Never mind, I'll open a PR.

@dhardy
Copy link
Member

dhardy commented Aug 19, 2020

Or rather, I already did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants