-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump MSRV to 1.36 #1011
Merged
Merged
Bump MSRV to 1.36 #1011
Commits on Aug 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 8057576 - Browse repository at this point
Copy the full SHA 8057576View commit details -
Configuration menu - View commit details
-
Copy full SHA for eef82c4 - Browse repository at this point
Copy the full SHA eef82c4View commit details -
Drop some unsafe code from
rand_core
The necessary standard library functions were stabilized with Rust 1.34. Our MSRV is 1.36.
Configuration menu - View commit details
-
Copy full SHA for 0432b06 - Browse repository at this point
Copy the full SHA 0432b06View commit details -
Configuration menu - View commit details
-
Copy full SHA for afc6bc6 - Browse repository at this point
Copy the full SHA afc6bc6View commit details -
This is possible thanks to `alloc` being implied by `std` builds since Rust 1.36.
Configuration menu - View commit details
-
Copy full SHA for f4746e1 - Browse repository at this point
Copy the full SHA f4746e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6911b8f - Browse repository at this point
Copy the full SHA 6911b8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 514e60d - Browse repository at this point
Copy the full SHA 514e60dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e97a7e6 - Browse repository at this point
Copy the full SHA e97a7e6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 73422d3 - Browse repository at this point
Copy the full SHA 73422d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e27f41 - Browse repository at this point
Copy the full SHA 6e27f41View commit details -
Use
chunks_exact_mut
for slightly better performanceThe results from master, using unsafe code: ``` gen_bytes_chacha12: 2,733,838 ns/iter (+/- 181,694) = 374 MB/s gen_bytes_chacha20: 4,339,602 ns/iter (+/- 237,793) = 235 MB/s gen_bytes_chacha8: 1,918,279 ns/iter (+/- 103,581) = 533 MB/s ``` The results of the new code using `chunks_exact_mut` (this commit): ``` gen_bytes_chacha12: 3,049,147 ns/iter (+/- 220,631) = 335 MB/s gen_bytes_chacha20: 4,645,772 ns/iter (+/- 269,261) = 220 MB/s gen_bytes_chacha8: 2,214,954 ns/iter (+/- 1,745,600) = 462 MB/s ``` The results of using `chunks_mut` (before this commit): ``` gen_bytes_chacha12: 3,492,109 ns/iter (+/- 164,638) = 293 MB/s gen_bytes_chacha20: 5,087,706 ns/iter (+/- 249,219) = 201 MB/s gen_bytes_chacha8: 2,700,197 ns/iter (+/- 524,148) = 379 MB/s ```
Configuration menu - View commit details
-
Copy full SHA for e40851a - Browse repository at this point
Copy the full SHA e40851aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 23e02db - Browse repository at this point
Copy the full SHA 23e02dbView commit details -
Configuration menu - View commit details
-
Copy full SHA for d74e800 - Browse repository at this point
Copy the full SHA d74e800View commit details -
Configuration menu - View commit details
-
Copy full SHA for 422bb44 - Browse repository at this point
Copy the full SHA 422bb44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11439b5 - Browse repository at this point
Copy the full SHA 11439b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0913bc7 - Browse repository at this point
Copy the full SHA 0913bc7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2bc54d0 - Browse repository at this point
Copy the full SHA 2bc54d0View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.