Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict rand::rngs::adapter to std #1027

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

vks
Copy link
Collaborator

@vks vks commented Aug 28, 2020

See #911.

@dhardy I'm not sure whether more changes were intended?

@vks vks requested a review from dhardy August 28, 2020 14:32
@vks vks mentioned this pull request Aug 28, 2020
19 tasks
Copy link
Member

@dhardy dhardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd forgotten about that. Sure, this looks good!

@dhardy
Copy link
Member

dhardy commented Aug 28, 2020

@vks could you check the docs locally before merging (the cfg thing)? Looks like it will be fine.

@vks
Copy link
Collaborator Author

vks commented Aug 28, 2020

@dhardy Are you referring to #[cfg_attr(doc_cfg, doc(cfg(feature = "std")))]? I do not how to invoke rustdoc so that this gets used.

@dhardy
Copy link
Member

dhardy commented Aug 28, 2020

It's in the Cargo.toml:

RUSTDOCFLAGS="--cfg doc_cfg" cargo +nightly doc --all-features --no-deps --open

@vks
Copy link
Collaborator Author

vks commented Aug 28, 2020

This works as intended!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants