Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix next_u64_via_fill; rand_core changelog #1061

Merged
merged 3 commits into from
Oct 27, 2020
Merged

Fix next_u64_via_fill; rand_core changelog #1061

merged 3 commits into from
Oct 27, 2020

Conversation

dhardy
Copy link
Member

@dhardy dhardy commented Oct 19, 2020

Fixes #1026 and updates rand_core's changelog

Review please @vks?

@dhardy
Copy link
Member Author

dhardy commented Oct 19, 2020

@josephlr @nagisa I added a fix for #984. I believe we should add something similar to getrandom?

vks
vks approved these changes Oct 19, 2020
View reviewed changes
Copy link
Collaborator

@vks vks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vks
Copy link
Collaborator

vks commented Oct 27, 2020

Let's merge this.

@vks vks merged commit fde4113 into rust-random:master Oct 27, 2020
@CAD97 CAD97 mentioned this pull request Dec 21, 2020
Merged
@sync-by-unito sync-by-unito bot mentioned this pull request Dec 21, 2020
Closed
This was referenced Mar 9, 2021
Merged
Open
Open
@dependabot dependabot bot mentioned this pull request Mar 16, 2021
Closed
@klensy klensy mentioned this pull request Jul 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vks vks vks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix next_u64_via_fill to use little endian order
2 participants
@dhardy @vks