Move Alias-method WeightedIndex to rand_distr #945
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is ~500 lines of code that we don't need in the main Rand crate IMO. (The reason
WeightedIndex
is there is that it is used by theseq
module; but thealias_method
variant is not since it's initialisation cost makes it completely inappropriate for this single-use API.)Question: should we deprecate the
weighted
pub module inrand
, since this module doesn't need to be public now? (I guess this might require some re-exports or something internally, but we can do it.)Similarly, the
weighted
pub module andalias_method
sub-module inrand_distr
seem somewhat unnecessary.