Update to rand master #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhardy
commented
May 25, 2024
Comment on lines
102
to
110
| #[inline] | ||
| fn from_rng<R: RngCore>(rng: R) -> Result<Self, Error> { | ||
| BlockRng::<Hc128Core>::from_rng(rng).map(Hc128Rng) | ||
| fn from_rng(rng: impl RngCore) -> Self { | ||
| Hc128Rng(BlockRng::<Hc128Core>::from_rng(rng)) | ||
| } | ||
|
|
||
| #[inline] | ||
| fn try_from_rng<R: TryRngCore>(rng: R) -> Result<Self, R::Error> { | ||
| BlockRng::<Hc128Core>::try_from_rng(rng).map(Hc128Rng) | ||
| } |
There was a problem hiding this comment.
In many cases, I think we need to implement both of these. Annoying, but not terrible.
There was a problem hiding this comment.
As I suggested some time ago, in the new release cycle it may be worth to drop the block stuff completely. I will try to do a draft PR later.
Comment on lines
+770
to
+773
| impl<F> rand_core::TryRngCore for JitterRng<F> | ||
| where | ||
| F: Fn() -> u64 + Send + Sync, | ||
| { |
There was a problem hiding this comment.
We can't use impl_try_rng_from_rng_core here. Ideally it would support types with generics, but probably not worth bothering.
The test fails with CoarseTimer on one test target, showing that test_timer does something useful.
newpavlov
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily, we patch this repo to use rand from git. Not ideal, but: