consider running cargo audit with --deny-warnings enabled #52
Labels
good first issue
Good for newcomers
Comments
lauralt
added a commit
to lauralt/rust-vmm-ci
that referenced
this issue
Jan 11, 2022
It is better to fail on warnings as well when running `cargo audit` so we can catch problems in time. Fixes rust-vmm#52. Signed-off-by: Laura Loghin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
According to this comment, breaking changes related to cargo audit (which may turn into errors in time, see this thread and this PR) can be caught earlier if we run
cargo auditwith--deny-warningsenabled.If we choose to enable this flag,
cargo auditwill also fail if we expose inCargo.tomla version that was yanked. An example would bevm-superio: 0.1.0 was yanked, butmasterstill points to 0.1.0 inCargo.toml(with other commits on top). Basically, after we yank a version,cargo audit --deny-warningwill force us to release a new version on the branch on which we are running the test if the toml file is pointing to the yanked version (which sounds pretty reasonable).The text was updated successfully, but these errors were encountered: