Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: windows-sys 0.48.0 → 0.52.0 #1680

Merged

Conversation

ErichDonGubler
Copy link
Contributor

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality

@MarijnS95
Copy link
Member

What does build mean in the title? Isn't this part of the glutin runtime crate?

@ErichDonGubler
Copy link
Contributor Author

@MarijnS95: Ah, that's a convention from certain communities that use Conventional Commits; this cheat sheet describes well how I've seen it used, which is:

Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)

I can alter or remove the prefix if you want. Just LMK!

@MarijnS95
Copy link
Member

I've never liked "conventional commits" for e.g. this reason. What does "build" have to do with "external dependencies"?

@ErichDonGubler
Copy link
Contributor Author

I mean, Rust developers in particular quite literally cargo build dependencies into a binary. It doesn't sound conceptually distant to me, but I understand if you prefer a different prefix (or a system of authoring history outside of Conventional Commits).

My offer to change the commit message still stands.

@kchibisov kchibisov merged commit 700096f into rust-windowing:master Jun 6, 2024
43 checks passed
@kchibisov
Copy link
Member

Generally, the title prefix should reflect the subsystem, in this case it was primary wgl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants