Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winapi to 0.3 #346

Merged
merged 6 commits into from
Dec 24, 2017
Merged

Update winapi to 0.3 #346

merged 6 commits into from
Dec 24, 2017

Conversation

GabrielMajeri
Copy link
Contributor

@retep998 announced that winapi 0.3 is feature complete, and that

people should start porting and testing against the git version to ensure everything works before I finally publish winapi 0.3.

This pull request updates winit to use the new winapi, in preparation for its stable release.

@tomaka
Copy link
Contributor

tomaka commented Nov 11, 2017

Thanks.

What's the strategy, though? Do we merge this in master in the hopes that winapi 0.3 gets released before a new version of winit is needed, or do we let this PR sit?

@GabrielMajeri
Copy link
Contributor Author

GabrielMajeri commented Nov 11, 2017

I will keep this pull request updated and wait for a new winapi version to be released.

I wrote this pull request to check if it is possible to update, resolve incompatibilities, etc.

@tomaka
Copy link
Contributor

tomaka commented Dec 18, 2017

winapi 0.3 has been released. This needs a rebase/a merge and we're good to go.

Cargo.toml Outdated
kernel32-sys = "0.2"
dwmapi-sys = "0.1"
[target.'cfg(target_os = "windows")'.dependencies.winapi]
git = "https://github.com/retep998/winapi-rs"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change this to version = "0.3".

@GabrielMajeri
Copy link
Contributor Author

@tomaka Is there anything else that has to be done before this pull request can be merged?

@tomaka tomaka merged commit d92666c into rust-windowing:master Dec 24, 2017
@GabrielMajeri GabrielMajeri deleted the update-winapi branch December 24, 2017 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants