Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly demarcate platform support #3887

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Explicitly demarcate platform support #3887

merged 1 commit into from
Sep 20, 2024

Conversation

notgull
Copy link
Member

@notgull notgull commented Aug 23, 2024

As discussed in today's meeting, this commit creates two tiers of
support. Tier 1, which is what we actively test, and Tier 2, what we
hope compiles.

FEATURES.md Outdated Show resolved Hide resolved
@notgull notgull force-pushed the notgull/platform branch 2 times, most recently from d0923f4 to fbfad5c Compare August 23, 2024 15:51
@kchibisov
Copy link
Member

Should probably put it in a separate file, since we'll remove the FEATURES.md and then probably should also include it in the docs somehow?

@notgull notgull force-pushed the notgull/platform branch 2 times, most recently from 84b1579 to c5abd0c Compare August 23, 2024 23:44
@notgull
Copy link
Member Author

notgull commented Aug 23, 2024

Should probably put it in a separate file, since we'll remove the FEATURES.md and then probably should also include it in the docs somehow?

Done and done

@notgull
Copy link
Member Author

notgull commented Aug 23, 2024

For the initial draft here I've gone with more platforms than we probably need. I think all the tier 1's are necessary, since we actively test them in CI and they directly correspond to the canonical versions of the winit backend's platforms.

For the tier 2's:

  • ARM windows is becoming more popular, so we should make sure our bases are covered there.
  • Do we want to support Windows 7? I added it here for discussion. I think we should, since lots of computers (especially old ones) still run Win7.
  • Alpine Linux is sufficiently popular that I think we should be building musl. Same with FreeBSD. Not sure about NetBSD but issues have been filed on it in the past so I've added it.
  • Other architecture Linux is fair game. I think we should be building ARM, I can take or leave the rest.

Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once the data is deduplicated somehow (see first comment)

src/lib.rs Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@notgull notgull force-pushed the notgull/platform branch 2 times, most recently from ceb486d to dd5f448 Compare September 8, 2024 06:47
Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this requires a tier 3?
E.g. tier 2 is actually tested in CI, tier 3 is not but we believe it should work?
Unless we want to actually just go ahead and test them in CI (which I would be in favor of), then we should do this right here.

Or am I missing something?

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and adjusted the wording around Web as I suggested.

As discussed in today's meeting, this commit creates two tiers of
support. Tier 1, which is what we actively test, and Tier 2, what we
hope compiles.

Signed-off-by: John Nunley <[email protected]>
Co-authored-by: daxpedda <[email protected]>
@notgull notgull merged commit 4f1c5b6 into master Sep 20, 2024
58 checks passed
@notgull notgull deleted the notgull/platform branch September 20, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants