-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent winit from overriding LSUIElement in package manifests #3920
Prevent winit from overriding LSUIElement in package manifests #3920
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with comments resolved, thanks!
@madsmtm addressed your comments, and thanks for the quick review! I've tested with a branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! And yeah, your testing is good enough.
Awesome, thanks! |
Fixes #261
Essentially, MacOS users of applications that use
winit
were unable to setLSUIElement
in theirpackage manifest to make the app behave as an agent app, even if the application itself wasn't
enforcing anything. This was because
winit
was using a default value ofActivationPolicy:Regular
if none was provided, overriding anything in the package manifest.
So, make
with_activation_policy
override package manifest only if explicitly specified.See ActivationPolicy docs, LSUIElement docs.
Tested with a branch off of v0.30.4, since v0.30.5 (clean) breaks the build of the application I'm using.
changelog
module if knowledge of this change could be valuable to users