-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows fullscreen toggle on windows that started invisible #898
Conversation
If one created a window with "with_visibility(false)" and then done "show()" then "set_fullscreen" wasn't working properly and hid the window because the internal WindowFlags was still stored as WindowFlags::VISIBLE = false.
Thanks for the PR! Could you rebase this onto the |
I think this has already been fixed on master, actually. |
Thanks, we haven't upgraded and tested 0.20 yet but great if it has been fixed there with/after the big refactor. Can confirm later when we upgrade |
Looks like I was wrong about this being fixed on master :V! The issue I was running into was fixed by the changes included in this patch, so I've updated them for master and re-submitted them as #1345, so this should be addressed in the next release. |
Thanks! |
If one created a window with
with_visibility(false)
and then doneshow()
thenset_fullscreen
wasn't working properly and hid the window because the internalWindowFlags
was still stored asWindowFlags::VISIBLE = false
.CHANGELOG.md
if knowledge of this change could be valuable to users