Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows fullscreen toggle on windows that started invisible #898

Closed

Conversation

repi
Copy link
Contributor

@repi repi commented Jun 3, 2019

If one created a window with with_visibility(false) and then done show() then set_fullscreen wasn't working properly and hid the window because the internal WindowFlags was still stored as WindowFlags::VISIBLE = false.

  • Tested on all platforms changed
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

repi added 2 commits June 3, 2019 23:38
If one created a window with "with_visibility(false)" and then done "show()" then "set_fullscreen" wasn't working properly and hid the window because the internal WindowFlags was still stored as WindowFlags::VISIBLE = false.
@Osspial
Copy link
Contributor

Osspial commented Jun 10, 2019

Thanks for the PR! Could you rebase this onto the eventloop-2.0 new master branch?

@Osspial Osspial changed the base branch from master to winit-legacy June 13, 2019 05:27
@Osspial
Copy link
Contributor

Osspial commented Aug 27, 2019

I think this has already been fixed on master, actually.

@repi
Copy link
Contributor Author

repi commented Aug 29, 2019

Thanks, we haven't upgraded and tested 0.20 yet but great if it has been fixed there with/after the big refactor. Can confirm later when we upgrade

@goddessfreya goddessfreya added DS - windows C - waiting on maintainer A maintainer must review this code labels Nov 11, 2019
@Osspial
Copy link
Contributor

Osspial commented Dec 29, 2019

It looks like this particular issue has been addressed, so I'm going to close this PR. However, it looks like the test-case you describe is still causing some unrelated funky behavior which I'll look into.

Looks like I was wrong about this being fixed on master :V! The issue I was running into was fixed by the changes included in this patch, so I've updated them for master and re-submitted them as #1345, so this should be addressed in the next release.

@repi
Copy link
Contributor Author

repi commented Dec 29, 2019

Thanks!

@Jake-Shadle Jake-Shadle deleted the win-show-hide-fix branch April 25, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C - waiting on maintainer A maintainer must review this code DS - windows
Development

Successfully merging this pull request may close these issues.

3 participants