-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iconv): implement iconv and encodings : ASCII, (unicode defined encodings)utf8, utf16, utf32 #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main comment is about a non-streaming implementation. Is streaming easy or difficult?
For the user, reading everything into memory is a challenge for very large files.
i've replaced with chain of iterator consumption(with a circular buffer of max size 10000 bytes)..hence large files will work with very low memory footprint i.e streaming has been enabled |
Instead of following a dynamic library loading method(which GNU does) we have gone for static library(since we have small set of encodings right now), this adds on less complexity for dev purpose as well,
FYI: we can always move to a dynamic library approach in the future if we need...as the encoding follows the following flow
FROM ENCODING -> UCS-4 FORMAT(Intermediate format in our case) -> TO ENCODING