time: Locales #340
Merged
time: Locales #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgarzik
reviewed
Oct 18, 2024
datetime/tests/time/mod.rs
Outdated
| @@ -72,22 +85,45 @@ fn run_test_time( | |||
| assert!(stderr.contains(expected_error)); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_smoke_help() { | |||
There was a problem hiding this comment.
This seems like a test that will break every time the command line usage is updated? "fragile" test is sub-optimal.
datetime/time.rs
Outdated
| about = gettext("time - time a simple command or give resource usage"), | ||
| help_template = gettext("{about-with-newline}\nUsage: {usage}\n\nArguments:\n{positionals}\n\nOptions:\n{options}") | ||
| help_template = gettext("{about}\n\nUsage: {usage}\n\nArguments:\n{positionals}\n\nOptions:\n{options}"), | ||
| version = env!("CARGO_PKG_VERSION"), |
There was a problem hiding this comment.
-
is this
version =setting required of all posixutils utilities? Surely the default value is correct and wanted? -
is a help template for each posixutils utility required, in order to support translation?
There was a problem hiding this comment.
- No. Fixed.
- Yes, but the help template may differ
jgarzik
reviewed
Oct 18, 2024
| help_template = gettext("{about-with-newline}\nUsage: {usage}\n\nArguments:\n{positionals}\n\nOptions:\n{options}") | ||
| help_template = gettext("{about}\n\nUsage: {usage}\n\nArguments:\n{positionals}\n\nOptions:\n{options}"), | ||
| disable_help_flag = true, | ||
| disable_version_flag = true, |
There was a problem hiding this comment.
Why disable? Is this necessary for gettext-rs to translate the "Print help" string?
There was a problem hiding this comment.
It is disappointing to replicate this across many utilities :(. Oh well; what must be done must be done. We want complete translation support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current status:
Unresolved issues: