Make rustler_sys forward compatible #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filmor
force-pushed
the
rustler-sys-forward-compat
branch
from
cd32cd4
to
2c28705
Compare
philss
approved these changes
May 14, 2023
| nif_version.0, nif_version.1, MAX_SUPPORTED_VERSION.0, MAX_SUPPORTED_VERSION.1 | ||
| ); | ||
| nif_version = MAX_SUPPORTED_VERSION; | ||
| } |
| // Activate all config flags for the supported NIF versions | ||
| for minor in 0..=nif_version.1 { | ||
| println!("cargo:rustc-cfg=nif_{}_{}", nif_version.0, minor); | ||
| } |
|
If #537 is agreed on, we don't need to merge this one. If it requires more discussion, we can merge this and publish it as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
rustler_sysforward compatible by falling back to the highest available version as long as the NIF major version matches.