Add github workflows #519
Merged
Add github workflows #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kvark
reviewed
Dec 5, 2020
| RUST_BACKTRACE: 1 | ||
| strategy: | ||
| matrix: | ||
| os: [windows-latest, ubuntu-latest, macos-latest] |
There was a problem hiding this comment.
that's a whole lot of build: 3 * 2 * 2 in total. Can we perhaps mix and match those into fewer builds?
There was a problem hiding this comment.
I was actually considering adding more builds by adding all of the different permutations of features (i.e. none, mint, serde, mint+serde). This is what the strategy matrix is for :)
I could certainly remove the windows and macos builds, but is it actually an improvement? Yes there are 3 * 2 * 2 total builds here, but they run in parallel and the entire CI process finishes in under 3 minutes. I don't consider this to be excessive. I'd much prefer to run CI on all the major platforms and only reduce this if there's an issue with long build queues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.