Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: check semver compat #226

Merged
merged 1 commit into from
Oct 26, 2023
Merged

ci: check semver compat #226

merged 1 commit into from
Oct 26, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Oct 26, 2023

Use cargo-semver-checks-action in CI to try and catch semver breaking changes being made without the correct Cargo.toml version update.

Note: not perfect - this check passing is necessary but not sufficient for maintaining semver.

Use `cargo-semver-checks-action` in CI to try and catch semver breaking
changes being made without the correct `Cargo.toml` version update.

Note: not perfect - this check passing is necessary but not sufficient
for maintaining semver.
@cpu cpu self-assigned this Oct 26, 2023
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cpu
Copy link
Member Author

cpu commented Oct 26, 2023

I'm going to port our usual branch protection setup to this repo after this lands. Looks like it's a bit loosey goosey right now.

@cpu cpu merged commit 920fc2f into rustls:main Oct 26, 2023
10 checks passed
@cpu cpu deleted the cpu-semver-ci-check branch October 26, 2023 14:52
@cpu
Copy link
Member Author

cpu commented Oct 26, 2023

I'm going to port our usual branch protection setup to this repo after this lands

Done. Updated to:

  • Require PR approval
  • Require CI status checks pass
  • Require using the merge queue with the rebase merge strategy.

Administrative override is still permitted. It's pretty 1:1 with rustls/rustls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants