Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server name #11

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Server name #11

merged 6 commits into from
Nov 23, 2023

Conversation

djc
Copy link
Member

@djc djc commented Nov 21, 2023

No description provided.

@djc djc requested review from cpu and ctz November 21, 2023 11:19
ctz
ctz approved these changes Nov 21, 2023
View reviewed changes
src/server_name.rs Show resolved Hide resolved
This was referenced Nov 21, 2023
Merged
Merged
cpu
cpu approved these changes Nov 21, 2023
View reviewed changes
src/server_name.rs Outdated Show resolved Hide resolved
src/server_name.rs Outdated Show resolved Hide resolved
@djc djc force-pushed the server-name branch 3 times, most recently from 9fd2042 to c6cdc9e Compare November 23, 2023 09:07
@djc djc force-pushed the server-name branch 2 times, most recently from c42904c to 6da75ea Compare November 23, 2023 09:15
@djc
Copy link
Member Author

djc commented Nov 23, 2023

I've added two commits:

  • One commit to replace the IP parsing code from webpki with IP parsing code from core. This supports a wider range of input -- as far as I can tell, only for IPv6, where compressed addresses were out of scope for webpki's implementation. Note that rustls was already relying on the core/std implementation for parsing anyway. This also removes a bunch of tests that checked that the implementation indeed failed to parse compressed IPv6 addresses.
  • One commit to add notes to the docstrings for IpAddr, Ipv4Addr and Ipv6Addr to exempt their identity from semver-stability, so that we can reserve the right to swap them out for the actual core::net types when those are stabilized without requiring a semver-incompatible version bump.

cpu
cpu approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recent updates LGTM

@djc djc added this pull request to the merge queue Nov 23, 2023
Merged via the queue into main with commit cfbd49b Nov 23, 2023
@djc djc deleted the server-name branch November 23, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsha jsha jsha left review comments

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djc @jsha @cpu @ctz