Fix some new 1.79 clippy findings #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids the risk of type inference somehow changing our SAFETY
claim.
```
error: transmute used without annotations
--> src/server_name.rs:445:27
|
445 | unsafe { mem::transmute::<_, [u8; 16]>(addr16) },
| ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider adding missing annotations: `transmute::<[u16; 8], [u8; 16]>`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_transmute_annotations
= note: `-D clippy::missing-transmute-annotations` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::missing_transmute_annotations)]`
```
Of the form:
```
error: unnecessary structure name repetition
--> src/server_name.rs:136:32
|
136 | pub fn borrow(&'a self) -> DnsName<'_> {
| ^^^^^^^^^^^ help: use the applicable keyword: `Self`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#use_self
= note: `-D clippy::use-self` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::use_self)]`
```
djc
approved these changes
Jun 14, 2024
|
I did a quick pass through the other repo scheduled CI runs from yesterday and it looks like this was the only one that had 1.79 lint findings 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch fixes two new classes of clippy findings from the just-released 1.79 toolchain.