Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement std::error::Error for pem::Error #63

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Implement std::error::Error for pem::Error #63

merged 2 commits into from
Oct 14, 2024

Conversation

djc
Copy link
Member

@djc djc commented Oct 11, 2024 •
edited
Loading

Proposed release notes

  • In 1.9.0 we forgot to implement std::error::Error for the new pem::Error type. Add it.

@djc djc requested review from cpu and ctz October 11, 2024 10:07
ctz
ctz approved these changes Oct 11, 2024
View reviewed changes
src/pem.rs Outdated Show resolved Hide resolved
cpu
cpu approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

Can you add proposed release notes?

@djc
Copy link
Member Author

djc commented Oct 14, 2024

Added.

cpu
cpu approved these changes Oct 14, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🚀

@djc djc added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 05ca122 Oct 14, 2024
28 checks passed
@djc djc deleted the pem-error branch October 14, 2024 12:34
@djc
Copy link
Member Author

djc commented Oct 15, 2024

  • Published rustls-pki-types v1.10.0 at registry crates-io
  • [new tag] v/1.10.0 -> v/1.10.0
  • Release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu approved these changes

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @cpu @ctz