server: specific err for config w/o cert resolver #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we made the server config builder use an out param for the built config it allowed us to return an error when building a config without a cert resolver. At the time we used `RUSTLS_RESULT_GENERAL`, but this offers no significant hint at the root cause. This commit introduces a new `RUSTLS_RESULT_NO_CERT_RESOLVER` error and updates the impl and unit test to use it.
ctz
approved these changes
Oct 4, 2024
I'll fix these findings separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we made the server config builder use an out param for the built config it allowed us to return an error when building a config without a cert resolver. At the time we used
RUSTLS_RESULT_GENERAL, but this offers no significant hint at the root cause. This commit introduces a newRUSTLS_RESULT_NO_CERT_RESOLVERerror and updates the impl and unit test to use it.Resolves #217