Separate online smoke tests from main CI #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests communicate with 3rd party servers that are outside of our control, and are prone to occasionally flaking. Instead of running these tests by default this commit marks them as ignored. We can opt-in to running them with `cargo test ... -- --ignored`.
This workflow is separate from the main workflow and runs the `--ignored` smoke tests that rely on (often flaky) 3rd party servers. We run this CI workflow on a daily schedule, or on-demand with a trigger, separate from the main workflow.
djc
approved these changes
Jul 30, 2024
|
Merging with one review since this is pretty boring test shuffling. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests communicate with 3rd party servers that are outside of our control, and are prone to occasionally flaking.
Instead of running these tests by default this branch marks them as ignored. A new separate, schedule workflow is added to CI that invokes cargo test with the required argument to run the otherwise-ignored smoke tests.