-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: fix deprecations, MSRV tests. #30
Conversation
The remaining failure appears to be because
EDIT: Filed an upstream issue about this: BurntSushi/memchr#136 |
The former is not maintained, and produces warnings in GitHub Actions due to node-js deprecations. The latter is used by the other Rustls ecosystems projects and actively maintained.
Previously there was one job that ran clippy across all supported operating systems for both the latest stable, and the MSRV Rust toolchains. This commit splits that job into two: one for stable and one for the MSRV toolchain. This will make it easier to customize MSRV specific settings in a subsequent commit.
This commit adds a variation of the existing `clippy-ci` alias that only tests the `--lib` target. This is intended to be used when linting with the MSRV, where we don't want dev dependencies and other non-essential code being linted with the MSRV toolchain.
Unfortunately Rust 1.64.0 is the oldest toolchain version that we can get working with cargo-ndk, which is required for building *ring* for the Android targets. The prior MSRV was not being tested correctly in CI and so wasn't actually compatible with the crate as it stands today.
With an MSRV of 1.64.0 we can use the latest cargo-ndk release in the v2.12.x stream when doing our MSRV testing for the Android target. The 3.0.x and 3.1.x streams require a more aggressive MSRV than we can support at this time.
Clippy is flagging a couple instances of this: ``` error: unnecessary closure used with `bool::then` --> src/verification/android.rs:251:18 | 251 | .map(|o| (!o.is_null()).then(|| o)) | ^^^^^^^^^^^^^^^---------- | | | help: use `then_some(..)` instead: `then_some(o)` | ``` This commit applies the recommended fix.
This commit adds a cron schedule to the CI workflow so we can catch things like new clippy breakages sooner.
This will allow using the merge queue feature.
b1c46a9
to
8489d3a
Compare
Thanks for the reviews/input on this work folks. It ended up being hairier than I expected! 😅 |
Description
This branch resolves the remaining GitHub warnings from the
actions-rs
tasks. It also appears that the MSRV related tests weren't working properly in CI, masking some failures that were uncovered with the switch todtolnay/rust-toolchain
.I recommend reviewing this commit-by-commit. The top-level highlights:
--lib
target.cargo ndk
and transitive deps.Resolves #26