webpki-ccadb: distrust any CA with a distrust after date #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit update the CCADB codegen to consider any root CA with a distrust for TLS after date as not trusted, irrespective of the distrust date. The rustls/webpki ecosystem this crate supports does not have the capability to enforce a "active distrust" of a TLS trust anchor in the Mozilla root program that has a "Distrust for TLS After Date" date in CCADB. Given this constraint we choose to remove roots immediately when they are given a distrust after date. This is _more_ aggressive than the Mozilla root program but requires no new features implemented in downstream crates. Users needing more nuanced root program enforcement should consider using the rustls-platform-verifier crate.
djc
approved these changes
Jun 11, 2024
ctz
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit update the CCADB codegen to consider any root CA with a distrust for TLS after date as not trusted, irrespective of the distrust date.
The rustls/webpki ecosystem this crate supports does not have the capability to enforce a "active distrust" of a TLS trust anchor in the Mozilla root program that has a "Distrust for TLS After Date" date in CCADB. Given this constraint we choose to remove roots immediately when they are given a distrust after date. This is more aggressive than the Mozilla root program but requires no new features implemented in downstream crates. Users needing more nuanced root program enforcement should consider using the rustls-platform-verifier crate.
Updates #72 (not yet closing, because the CCADB distrust after date hasn't landed to regenerate/remove the root)