-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
webpki-root-certs 0.26.4 release #76
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, since there really isn't a need to publish webpki-roots 0.26.4, we could release webpki-root-certs at 0.26.3 instead?
I think the promise to release in lockstep is a little tricky, and I'm not sure it's all that helpful in the end? It's fine as an aspirational thing but I'm not sure it'll always be practical. |
What I don't love about that is if you clone the repo and check out the v/0.26.3 tag there's no |
Fair, I will remove that 👍 |
I don't think we need to do it 100% all of the time, but more like the "normal" release flow for this repo should be to release both, with the same version. That means we don't need to bifurcate the release notes or tags. For this initial release, I would suggest not publishing webpki-roots 0.26.4. Then the next release would be 0.26.5 for both crates. |
That sounds OK to me. Should the version in |
Maybe move it forward to |
This prepares the initial version of `webpki-root-certs` as 0.26.4. The `webpki-roots` version is proactively set to `0.26.4-not-released`. As described, it will not be published to crates.io since the content is an exact match for 0.26.3. Going forward normal releases will most often increment and publish both crates at the same time as their content will be in sync.
Reworked the version change/commit message/release notes 👍 |
|
Since the 0.26.3 release has already been tagged before the
webpki-roots-crate
existed I think it makes sense to bump the version for the firstwebpki-roots-crate
release. We will not publish thewebpki-roots
0.26.4 release since it's identical to 0.26.3.Proposed release notes
webpki-root-certs
crate. This crate is similar towebpki-roots
, but for use with other projects that require the full self-signed X.509 certificate for each trusted root. This is unnecessary overhead forwebpki
andrustls
and you should prefer usingwebpki-roots
for these projects.