Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpki-root-certs 0.26.4 release #76

Merged
merged 1 commit into from
Aug 7, 2024
Merged

webpki-root-certs 0.26.4 release #76

merged 1 commit into from
Aug 7, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Aug 7, 2024

Since the 0.26.3 release has already been tagged before the webpki-roots-crate existed I think it makes sense to bump the version for the first webpki-roots-crate release. We will not publish the webpki-roots 0.26.4 release since it's identical to 0.26.3.

Proposed release notes

  • New webpki-root-certs crate. This crate is similar to webpki-roots, but for use with other projects that require the full self-signed X.509 certificate for each trusted root. This is unnecessary overhead for webpki and rustls and you should prefer using webpki-roots for these projects.

@cpu cpu self-assigned this Aug 7, 2024
Copy link
Member

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, since there really isn't a need to publish webpki-roots 0.26.4, we could release webpki-root-certs at 0.26.3 instead?

@djc
Copy link
Member

djc commented Aug 7, 2024

I think the promise to release in lockstep is a little tricky, and I'm not sure it's all that helpful in the end? It's fine as an aspirational thing but I'm not sure it'll always be practical.

@cpu
Copy link
Member Author

cpu commented Aug 7, 2024

we could release webpki-root-certs at 0.26.3 instead?

What I don't love about that is if you clone the repo and check out the v/0.26.3 tag there's no webpki-root-certs. I don't want to delete/recreate the tag so it seemed like a no-op point release for the one crate was the least bad option.

@cpu
Copy link
Member Author

cpu commented Aug 7, 2024

I think the promise to release in lockstep is a little tricky,

Fair, I will remove that 👍

@ctz
Copy link
Member

ctz commented Aug 7, 2024

I don't think we need to do it 100% all of the time, but more like the "normal" release flow for this repo should be to release both, with the same version. That means we don't need to bifurcate the release notes or tags.

For this initial release, I would suggest not publishing webpki-roots 0.26.4.

Then the next release would be 0.26.5 for both crates.

@cpu
Copy link
Member Author

cpu commented Aug 7, 2024

For this initial release, I would suggest not publishing webpki-roots 0.26.4.

That sounds OK to me. Should the version in webpki-roots/Cargo.toml remain at 0.26.3 in that case?

@ctz
Copy link
Member

ctz commented Aug 7, 2024

Maybe move it forward to version = "0.26.4-not-released"?

This prepares the initial version of `webpki-root-certs` as 0.26.4.
The `webpki-roots` version is proactively set to `0.26.4-not-released`.
As described, it will not be published to crates.io since the content is
an exact match for 0.26.3.

Going forward normal releases will most often increment and publish both
crates at the same time as their content will be in sync.
@cpu
Copy link
Member Author

cpu commented Aug 7, 2024

Reworked the version change/commit message/release notes 👍

@cpu cpu changed the title webpki-roots/webpki-root-certs: 0.26.3 -> 0.26.4 webpki-root-certs 0.26.4 release Aug 7, 2024
@cpu cpu requested a review from ctz August 7, 2024 15:24
@cpu cpu merged commit 10f8379 into rustls:main Aug 7, 2024
1 check passed
@cpu cpu deleted the cpu-0.26.4-prep branch August 7, 2024 15:27
@cpu
Copy link
Member Author

cpu commented Aug 7, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants