New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`web-sys` 0.3.65 broke semver for WebGPU #3686

Closed

mockersf opened this issue Nov 4, 2023 · 1 comment

Labels

bug

mockersf commented Nov 4, 2023

Describe the Bug

Version 0.3.65 of web-sys broke server, and crate using web-sys stopped compiling

Steps to Reproduce

Two examples used by wgpu:

set_bind_group_with_u32_array_and_f64_and_dynamic_offsets_data_length changed the type of one of it's parameter, now an Option
- on 0.3.64: https://docs.rs/web-sys/0.3.64/web_sys/struct.GpuRenderBundleEncoder.html#method.set_bind_group_with_u32_array_and_f64_and_dynamic_offsets_data_length
- on 0.3.65: https://docs.rs/web-sys/0.3.65/web_sys/struct.GpuRenderPassEncoder.html#method.set_bind_group_with_u32_array_and_f64_and_dynamic_offsets_data_length
GpuDepthStencilState::new added parameters
on 0.3.64: https://docs.rs/web-sys/0.3.64/web_sys/struct.GpuDepthStencilState.html#method.new
on 0.3.65: https://docs.rs/web-sys/0.3.65/web_sys/struct.GpuDepthStencilState.html#method.new

Expected Behavior

Continue compiling when depending on web-sys = "0.3"

Actual Behavior

It doesn't compile anymore

Additional Context

Those API need web_sys_unstable_apis. Does that mean they don't follow semver?

The text was updated successfully, but these errors were encountered:

mockersf added the bug label

Author

mockersf commented Nov 5, 2023

unstable APIs don't follow semver

mockersf closed this as completed

mockersf mentioned this issue

Update web sys 0.3.65 on branch 0.17 gfx-rs/wgpu#4631

Merged

3 tasks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment