Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update web sys 0.3.65 on branch 0.17 #4631

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

mockersf
Copy link
Contributor

@mockersf mockersf commented Nov 5, 2023

Checklist

  • Run cargo clippy.
  • Run cargo clippy --target wasm32-unknown-unknown if applicable.
  • Add change to CHANGELOG.md. See simple instructions inside file.

Connections
rustwasm/wasm-bindgen#3686
web-sys update to 0.3.65 broke WebGPU support.

Description
Bevy, using wgpu 0.17, doesn't compile for WebGPU anymore. tracking it down, web-sys 0.3.65 introduced some breaking changes, this PR makes it compile again.

Opening on the v0.17 branch because:

  • that's what Bevy is using
  • features used on trunk don't exist anymore
  • I couldn't get WebGPU working on trunk

Testing
Ran the example hello-triangle on WebGPU and it works

Copy link
Member

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! But waiting for merge for @cwfitzgerald , typically we only patch the latest release 0.18, not sure if we want to do another one on the 0.17 line for this.

I couldn't get WebGPU working on trunk

What problems are you hitting?

@cwfitzgerald cwfitzgerald merged commit 1ec0d15 into gfx-rs:v0.17 Nov 15, 2023
21 of 22 checks passed
@cwfitzgerald
Copy link
Member

Published as 0.17.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants