Adding in unintern function #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
RReverser
reviewed
Oct 23, 2019
| @@ -40,6 +40,14 @@ cfg_if! { | |||
| } | |||
| }) | |||
| } | |||
|
|
|||
| fn unintern_str(key: &str) { | |||
There was a problem hiding this comment.
Should we have some sort of reference counter perhaps? That is, if several parts of code use intern, but then one does unintern, maybe we shouldn't evict it yet?
There was a problem hiding this comment.
I figured that if you want that, it's easy enough to do your own ref-counting in your program.
I'm a bit wary of introducing too much complexity, it seems to me that ref-counting is orthogonal to interning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1386 (comment) for an example use-case for this.