Expose objects and functions from the JavaScript global scope #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can happen when a nested dependency crate exports things but the root crate doesn't use them. In these cases, it is fine to ignore the missing descriptor, because the thing it describes was removed as dead code.
These are bindings to JavaScript's standard, built-in objects and their methods and properties. This does *not* include any Web, Node, or any other JS environment APIs. Only the things that are guaranteed to exist in the global scope by the ECMAScript standard. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects
They aren't part of any public API, and are just an implementation detail of wasm-bindgen.
And here is the big issue with a big checklist: #275 |
ohanar
reviewed
Jun 19, 2018
tests/all/js_globals.rs
Outdated
| assert!(js::decode_uri("%E0%A4%A").is_err()); | ||
| } | ||
| "#) | ||
| .file("test.ts", r#" |
There was a problem hiding this comment.
This test.ts isn't needed anymore. The changes I made for WebIDL will automatically generate a test.ts equivalent to this one if no test.ts is found.
There was a problem hiding this comment.
Good catch! I forgot about that :)
tests/all/js_globals.rs
Outdated
| assert_eq!(x, "ABC%20abc%20123"); | ||
| } | ||
| "#) | ||
| .file("test.ts", r#" |
tests/all/js_globals.rs
Outdated
| } | ||
|
|
||
| #[allow(non_snake_case)] | ||
| mod Object { |
There was a problem hiding this comment.
Rather than adding an inline module, maybe a new directory should be added? (Especially in preparation for more to be added to js_globals.)
The testing infrastructure will add exactly this default `test.ts` when it isn't explicitly specified.
|
I've arrived a bit late to the party but this looks perfect!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are bindings to JavaScript's standard, built-in objects and their methods and properties.
This does not include any Web, Node, or any other JS environment APIs. Only the things that are guaranteed to exist in the global scope by the ECMAScript standard. They are available in the
wasm_bindgen::jsmodule when thejs_globalsfeature is enabled.https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects
This is intentionally an incomplete set of imports, and I intend to create a big issue with a big checklist of everything else that we need to add.
@ohanar @spastorino if one of you could review this, that would be very appreciated :)