Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement on IntoWasmAbi and FromWasmAbi docs #3855

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

improvement on IntoWasmAbi and FromWasmAbi docs #3855

wants to merge 3 commits into from

Conversation

alivarastepour
Copy link

@alivarastepour alivarastepour commented Feb 25, 2024 •
edited
Loading

resolves #3849

daxpedda
daxpedda reviewed Feb 25, 2024
View reviewed changes
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make it sound like the ABI is an actor doing something, compared to the relatively passive speech the original documentation used.

I'm not a native English speaker, but I find this way harder to read.

@alivarastepour
Copy link
Author

Hi @daxpedda
2 days ago the edited version sounded more comprehensible to me, but now I'm starting to find the original version comprehensive as well. However, I presume one reason contributing to this is that I've read the original version like a 100 times and I'm pretty sure it wasn't this comprehensive for the first 80 times. Let's see if anyone has anything to say for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daxpedda daxpedda daxpedda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: improvement on wasm_bindgen::convert::traits
2 participants
@alivarastepour @daxpedda