Fix flaky tests #4052
Merged
Fix flaky tests #4052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systemcluster
force-pushed
the
fix-flaky-test
branch
from
268188e
to
be1c590
Compare
Systemcluster
commented
Aug 6, 2024
daxpedda
requested changes
Aug 6, 2024
Systemcluster
force-pushed
the
fix-flaky-test
branch
from
be1c590
to
b50427b
Compare
daxpedda
approved these changes
Aug 6, 2024
|
It looks like this wasn't 100% successful, I'm still getting test failures, albeit much less. I don't know enough about |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know much about
hyperbut searching for the "error shutting down connection" error message in its code led me to attempt thegraceful_shutdownaddition, and I haven't had an example run fail since.