-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the CI runtime #4056
Improve the CI runtime #4056
Conversation
I'm happy to give it a final review already as-is, up to you when its ready! I believe the last three things we could do are:
Could all be done in a follow-up btw. |
e847f3d
to
957f84a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get it under 6 minutes, but the later commits touch up some details that might still be worthwile.
I'm done with the CI for a while, feel free to modify and force push this branch if something should change. I'll leave any additional improvements for you or someone else (or for me at some later time 🙂).
crates/example-tests/src/lib.rs
Outdated
@@ -364,6 +364,7 @@ pub async fn test_example( | |||
}; | |||
|
|||
conn.graceful_shutdown(); | |||
tokio::time::sleep(Duration::from_millis(100)).await; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it didn't work, maybe it's not (just) here after all? I'm pretty sure it's always the last test, so maybe the waiting needs to happen at a higher level (before shutting down tokio runtime?).
957f84a
to
3edbecc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Run wasm-bindgen crate tests with various environment variables" could still be split up, that ones the longest now.
I'm happy to merge it as-is if we can split out the caching.
3edbecc
to
f7edb03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work!
I know that there are many faster webpack alternatives ( I assume just running the loop in parallel is a bit easier though. |
I need to add (with this as a follow-up, and it only showing in linked CI runs) that adding sccache really doesn't seem to help much with the |
Follow-up to #4051, see there for prior discussion.
This splits up the longest-running CI jobs into smaller jobs to improve the CI runtime.
The overall usage didn't go down much, it's still around 100 minutes, but now it's spread out over more jobs.
(It's gotten a bit more stable slightly under the 100 minute mark with this PR, but not much.)
Additional changes are commented below.