Implement Ord for Position, RoomName, ObjectId and RawObjectId #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ASalvail
approved these changes
Aug 23, 2019
| @@ -23,6 +40,8 @@ pub struct RoomName { | |||
| /// | |||
| /// This is the same representation of the upper 16 bits of [`Position`]'s | |||
| /// packed representation. | |||
| /// | |||
| /// [`Position`]: crate::local::Position | |||
There was a problem hiding this comment.
Oh, great thanks, I saw the doc compiler complaining about that earlier!
There was a problem hiding this comment.
👍 I almost made a separate PR but decided just to include it in this one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements half of #226!
ObjectIdandRawObjectIdare per the specification from my last comment, andPosition/RoomNamesort byyfirst rather than byxfirst.